Revert p_mask to a list in DQA pipeline#35964
Merged
Rocketknight1 merged 2 commits intomainfrom Jan 30, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
Member
Author
|
Yep, this looks good - cc @Cyrilvallez for review! |
4 tasks
Cyrilvallez
approved these changes
Jan 29, 2025
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
Make sense to me! Thanks!
bursteratom
pushed a commit
to bursteratom/transformers
that referenced
this pull request
Feb 5, 2025
* p_mask back to being a list * Remove breakpoint
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
* p_mask back to being a list * Remove breakpoint
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
* p_mask back to being a list * Remove breakpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had two PRs to fix the same issue, #32076 and #32208. I don't think the conflict was noticed, and the fix in #32076 seems to cause issues! This PR tests reverting #32076 but keeping #32208 and seeing if that resolves everything.
Fixes #35948