Remove deprecated batch_size parameter#37007
Merged
gante merged 3 commits intohuggingface:mainfrom Mar 27, 2025
Merged
Conversation
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
Member
|
cc @gante |
gante
reviewed
Mar 26, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing it! 💛
Added a missing step to complete this PR
cyyever
force-pushed
the
batch_size
branch
2 times, most recently
from
1738711 to
496efdf
Compare
cyyever
changed the title
gante
approved these changes
Mar 27, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Thank you for iterating and making transformers better 🤗
This was referenced Apr 3, 2025
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
soghomon-b
pushed a commit
to soghomon-b/transformers
that referenced
this pull request
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's declared to be removed in 4.49.