Skip to content

feat: updated model card for qwen_2.5_vl#37099

Merged
stevhliu merged 17 commits intohuggingface:mainfrom
arkhamHack:update_qwen2.5vl_model_card
Apr 3, 2025
Merged

feat: updated model card for qwen_2.5_vl#37099
stevhliu merged 17 commits intohuggingface:mainfrom
arkhamHack:update_qwen2.5vl_model_card

Conversation

@arkhamHack
Copy link
Copy Markdown
Contributor

@arkhamHack arkhamHack commented Mar 29, 2025 •
edited by stevhliu
Loading

What does this PR do?

#36979
This pr updates the model card for Qwen2.5-VL

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions Bot marked this pull request as draft March 29, 2025 10:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 29, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@arkhamHack arkhamHack marked this pull request as ready for review March 29, 2025 10:23
@github-actions github-actions Bot requested a review from stevhliu March 29, 2025 10:23
@Rocketknight1
Copy link
Copy Markdown
Member

Rocketknight1 commented Mar 31, 2025

cc @stevhliu

@stevhliu stevhliu mentioned this pull request Mar 31, 2025
Closed
stevhliu
stevhliu reviewed Mar 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, just missing a few notes and quantization example!

Comment thread docs/source/en/model_doc/qwen2_5_vl.md Outdated
Comment thread docs/source/en/model_doc/qwen2_5_vl.md Outdated
Comment thread docs/source/en/model_doc/qwen2_5_vl.md
Comment thread docs/source/en/model_doc/qwen2_5_vl.md Outdated
arkhamHack and others added 5 commits April 1, 2025 04:28
@arkhamHack @stevhliu
applied suggested change 1
97107f0 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@arkhamHack
Merge branch 'main' into update_qwen2.5vl_model_card
d1b60f4
@arkhamHack @stevhliu
applied suggested change 2
a07c7dd 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@arkhamHack @stevhliu
applied suggested change 3
f68bbe3 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@arkhamHack
Merge branch 'main' into update_qwen2.5vl_model_card
79e5576
@arkhamHack arkhamHack requested a review from stevhliu April 1, 2025 08:39
@arkhamHack
Copy link
Copy Markdown
Contributor Author

arkhamHack commented Apr 1, 2025

hi @stevhliu . I have made the changes you requested. Could you review this pr? Thanks.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Apr 2, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu reviewed Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few more changes to go!

Comment thread docs/source/en/model_doc/qwen2_5_vl.md Outdated
Comment thread docs/source/en/model_doc/qwen2_5_vl.md Outdated
Comment thread docs/source/en/model_doc/qwen2_5_vl.md
Comment thread docs/source/en/model_doc/qwen2_5_vl.md
Comment thread docs/source/en/model_doc/qwen2_5_vl.md Outdated
max_pixels = 1024*28*28
processor = AutoProcessor.from_pretrained("Qwen/Qwen2.5-VL-7B-Instruct", min_pixels=min_pixels, max_pixels=max_pixels)
```
- We can implement flash attention 2 to speed up generation as shown below.
Copy link
Copy Markdown
Member

@stevhliu stevhliu Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this note

Copy link
Copy Markdown
Contributor Author

@arkhamHack arkhamHack Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive removed the flash attention 2 note from here . hope the code snippet before that is ok to stay.

Comment thread docs/source/en/model_doc/qwen2_5_vl.md Outdated
arkhamHack and others added 6 commits April 3, 2025 05:35
@arkhamHack @stevhliu
suggeested model card change 4
70e64e1 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@arkhamHack @stevhliu
updated model card wiht suggested change 5
12de7f2 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@arkhamHack @stevhliu
updated model card wiht suggested change 6
2ec452a 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@arkhamHack @stevhliu
updated model card wiht suggested change 7
b5af9a5 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@arkhamHack
Merge branch 'main' into update_qwen2.5vl_model_card
3d7f04f
@arkhamHack
feat: applied requested changes
e480dc2
@arkhamHack arkhamHack requested a review from stevhliu April 3, 2025 00:22
@arkhamHack
Copy link
Copy Markdown
Contributor Author

arkhamHack commented Apr 3, 2025 •
edited
Loading

Hi @stevhliu made the remaining changes. Just hope that the above comment i've left is fine though.

stevhliu
stevhliu approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@stevhliu stevhliu merged commit 1b29409 into huggingface:main Apr 3, 2025
10 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@arkhamHack @stevhliu @zucchini-nlp
feat: updated model card for qwen_2.5_vl (huggingface#37099)
81cc61d 
* feat: updated model card for qwen_2.5_vl

* applied suggested change 1

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* applied suggested change 2

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* applied suggested change 3

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* fix: made requested changes for quantization and notes

* suggeested model card change 4

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* updated model card wiht suggested change 5

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* updated model card wiht suggested change 6

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* updated model card wiht suggested change 7

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* feat: applied requested changes

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arkhamHack @Rocketknight1 @HuggingFaceDocBuilderDev @stevhliu