Skip to content

Add Fast Image Processor for Perceiver#37176

Merged
yonigozlan merged 8 commits intohuggingface:mainfrom
rootonchair:perceiver_fast_image_processor
Apr 14, 2025
Merged

Add Fast Image Processor for Perceiver#37176
yonigozlan merged 8 commits intohuggingface:mainfrom
rootonchair:perceiver_fast_image_processor

Conversation

@rootonchair
Copy link
Copy Markdown
Contributor

What does this PR do?

Related #36978

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions Bot marked this pull request as draft April 1, 2025 15:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@rootonchair rootonchair marked this pull request as ready for review April 1, 2025 15:53
@github-actions github-actions Bot requested review from ydshieh and yonigozlan April 1, 2025 15:54
Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice again @rootonchair, and thanks for adding tests! One little thing to simplify then LGTM

Comment thread src/transformers/models/perceiver/image_processing_perceiver_fast.py Outdated
…ast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there is an issue with formatting/styling, so let's do make style and make quality. Otherwise LGTM after getting @ArthurZucker final approval :)

@rootonchair rootonchair requested a review from yonigozlan April 11, 2025 20:01
@yonigozlan
Copy link
Copy Markdown
Member

Updating the branch and running the full CI. If everything pass I'll merge!

@yonigozlan yonigozlan merged commit e7f5724 into huggingface:main Apr 14, 2025
19 of 20 checks passed
@rootonchair rootonchair deleted the perceiver_fast_image_processor branch April 15, 2025 18:03
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
* add test and fast image processor

* make style

* Update src/transformers/models/perceiver/image_processing_perceiver_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* make style

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* add test and fast image processor

* make style

* Update src/transformers/models/perceiver/image_processing_perceiver_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* make style

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants