Add Fast Image Processor for VideoMAE #37191
Open
miguelscarv wants to merge 6 commits intohuggingface:mainfrom
Open
Add Fast Image Processor for VideoMAE #37191miguelscarv wants to merge 6 commits intohuggingface:mainfrom
miguelscarv wants to merge 6 commits intohuggingface:mainfrom
Conversation
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
81 tasks
3d56506 to
828804b
Compare
Author
|
Hey @yonigozlan Saw in #37611 that fast processors for video models aren't being merged, so guessing this PR won’t go through either. That said, would a fast image processor make sense for SmolVLM? It handles high-res images, so it could help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements a FastImageProcessor for the the VideoMAE model using BaseImageProcessorFast. Related #36978
Note:
test_can_compile_fast_image_processoras I'm using a M1 and don't have access to a NVIDIA GPU.test_slow_fast_equivalence_batchedis only able to pass when all images in the batch have a fixed width and height (by settingequal_resolution=Truein theself.image_processor_tester.prepare_image_inputs). If the width and height vary across videos, then there is a low chance of passing this test, i.e. it doesn't fail every time.Other than that, all tests passed.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@yonigozlan
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.