Skip to content

Add Fast PVT Processor#37204

Merged
yonigozlan merged 9 commits intohuggingface:mainfrom
keetrap:fast_pvt
Apr 23, 2025
Merged

Add Fast PVT Processor#37204
yonigozlan merged 9 commits intohuggingface:mainfrom
keetrap:fast_pvt

Conversation

@keetrap
Copy link
Copy Markdown
Contributor

@keetrap keetrap commented Apr 2, 2025

Related #36978
cc @yonigozlan

@github-actions github-actions Bot marked this pull request as draft April 2, 2025 11:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@keetrap keetrap marked this pull request as ready for review April 2, 2025 12:10
@github-actions github-actions Bot requested review from ydshieh and yonigozlan April 2, 2025 12:10
@yonigozlan yonigozlan mentioned this pull request Apr 2, 2025
Closed
81 tasks
yonigozlan
yonigozlan reviewed Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keetrap ! I think we can simplify even further

Comment thread src/transformers/models/pvt/image_processing_pvt_fast.py Outdated
Comment thread src/transformers/models/pvt/image_processing_pvt_fast.py Outdated
Comment thread src/transformers/models/pvt/image_processing_pvt_fast.py Outdated
yonigozlan
yonigozlan approved these changes Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for iterating @keetrap

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Apr 15, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@keetrap
Copy link
Copy Markdown
Contributor Author

keetrap commented Apr 15, 2025

@yonigozlan This test is failing here but passing locally.
PvtImageProcessingTest::test_slow_fast_equivalence_batched - AssertionError: 0.0011574935633689165 not less than or equal to 0.001

@yonigozlan yonigozlan merged commit b491f12 into huggingface:main Apr 23, 2025
20 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@keetrap @yonigozlan @zucchini-nlp
Add Fast PVT Processor (huggingface#37204)
3ba1853 
* Add Fast PVT Processor

* Update image_processing_pvt_fast.py

* Update image_processing_pvt_fast.py

* remove kwargs

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonigozlan yonigozlan yonigozlan approved these changes

@ydshieh ydshieh Awaiting requested review from ydshieh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keetrap @HuggingFaceDocBuilderDev @yonigozlan