Skip to content

Updated T5 model card with standardized format#37261

Merged
stevhliu merged 16 commits intohuggingface:mainfrom
ShararehY:t5-contribution
Apr 4, 2025
Merged

Updated T5 model card with standardized format#37261
stevhliu merged 16 commits intohuggingface:mainfrom
ShararehY:t5-contribution

Conversation

@ShararehY
Copy link
Copy Markdown
Contributor

@ShararehY ShararehY commented Apr 3, 2025

What does this PR do?

Updated T5 model card with standardized format

Fixes #36979

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu

@github-actions github-actions Bot marked this pull request as draft April 3, 2025 18:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@ShararehY ShararehY marked this pull request as ready for review April 3, 2025 18:52
@github-actions github-actions Bot requested a review from stevhliu April 3, 2025 18:52
@stevhliu stevhliu mentioned this pull request Apr 4, 2025
Closed
stevhliu
stevhliu reviewed Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, very clean! 👏

Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md
Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md Outdated
Comment thread docs/source/en/model_doc/t5.md
ShararehY and others added 11 commits April 4, 2025 14:11
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
f072fc8 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
1d367a4 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
b14136a 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
76af9e6 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
b293146 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
ff6c9fe 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
e863b3d 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
1b05224 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
fe18f64 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
16eb76d 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@ShararehY
Apply reviewer suggestions
99bc4cd
@ShararehY
Copy link
Copy Markdown
Contributor Author

ShararehY commented Apr 4, 2025

Hi @stevhliu , Thanks for the suggestions! I applied the changes, could you please review it again?

@ShararehY ShararehY requested a review from stevhliu April 4, 2025 18:38
stevhliu
stevhliu approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one tiny nit then we can merge :)

@ShararehY @stevhliu
Update docs/source/en/model_doc/t5.md
d7d6804 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Apr 4, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 46d7391 into huggingface:main Apr 4, 2025
10 checks passed
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Apr 5, 2025
@ShararehY @stevhliu @yuchenxie4645
Updated T5 model card with standardized format (huggingface#37261)
0ad69a1 
* Updated T5 model card with standardized format

* Updated T5 model card with standardized format, fixed typo

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Apply reviewer suggestions

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@ShararehY @stevhliu @zucchini-nlp
Updated T5 model card with standardized format (huggingface#37261)
7c0ea0d 
* Updated T5 model card with standardized format

* Updated T5 model card with standardized format, fixed typo

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Apply reviewer suggestions

* Update docs/source/en/model_doc/t5.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@MithraVardhan MithraVardhan mentioned this pull request Oct 15, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Community contributions] Model cards

3 participants

@ShararehY @HuggingFaceDocBuilderDev @stevhliu