Skip to content

36978 | Fast processor, Vivit#37270

Closed
samrae7 wants to merge 7 commits intohuggingface:mainfrom
samrae7:36978/vivit
Closed

36978 | Fast processor, Vivit#37270
samrae7 wants to merge 7 commits intohuggingface:mainfrom
samrae7:36978/vivit

Conversation

@samrae7
Copy link
Copy Markdown
Contributor

@samrae7 samrae7 commented Apr 4, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@zucchini-nlp
Copy link
Copy Markdown
Member

zucchini-nlp commented Apr 4, 2025

@samrae7 thanks for the PR! As you already mentioned this is a video-only processor which means that we'll deprecate using an image processor for these models in the near future. Given that and since model is not super high usage, I prefer to not add a fast processor yet. Adding directly fast video processor is already planned, and your help will be appreciated :)

@samrae7
Copy link
Copy Markdown
Contributor Author

samrae7 commented Apr 7, 2025

@samrae7 thanks for the PR! As you already mentioned this is a video-only processor which means that we'll deprecate using an image processor for these models in the near future. Given that and since model is not super high usage, I prefer to not add a fast processor yet. Adding directly fast video processor is already planned, and your help will be appreciated :)

Thanks @zucchini-nlp - makes sense. I will close this one and take another

@samrae7 samrae7 closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants