Skip to content

[WIP] Refactor attention modules in Bert-based models to use global attention functions#37494

Closed
Marcel256 wants to merge 2 commits intohuggingface:mainfrom
Marcel256:bert_attention
Closed

[WIP] Refactor attention modules in Bert-based models to use global attention functions#37494
Marcel256 wants to merge 2 commits intohuggingface:mainfrom
Marcel256:bert_attention

Conversation

@Marcel256
Copy link
Copy Markdown

What does this PR do?

Refactoring of the Attention Modules in bert-based models to use global attention functions.
Allows support of SDPA and flash attention for Bert models and potentially flex attention in the future

This is a first draft (Feedback appreciated)
Could solve:
#37105
#29129
#27957

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x ] Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant