Skip to content

Updated model card for mbart and mbart50#37619

Merged
stevhliu merged 11 commits intohuggingface:mainfrom
Vishesh-Mistry:update-mbart-model-card
Apr 22, 2025
Merged

Updated model card for mbart and mbart50#37619
stevhliu merged 11 commits intohuggingface:mainfrom
Vishesh-Mistry:update-mbart-model-card

Conversation

@Vishesh-Mistry
Copy link
Copy Markdown
Contributor

@Vishesh-Mistry Vishesh-Mistry commented Apr 18, 2025 •
edited by stevhliu
Loading

What does this PR do?

Addresses #36979 so that the documentation for mbart and mbart50 align with the standardized format for all model cards.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu, please let me know about any changes that may be required.

@github-actions github-actions Bot marked this pull request as draft April 18, 2025 17:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@Vishesh-Mistry Vishesh-Mistry marked this pull request as ready for review April 18, 2025 17:52
@github-actions github-actions Bot requested a review from stevhliu April 18, 2025 17:52
@stevhliu stevhliu mentioned this pull request Apr 18, 2025
Closed
stevhliu
stevhliu reviewed Apr 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Comment thread docs/source/en/model_doc/mbart.md Outdated
Comment thread docs/source/en/model_doc/mbart.md Outdated
Comment thread docs/source/en/model_doc/mbart.md Outdated
Comment thread docs/source/en/model_doc/mbart.md Outdated
Comment thread docs/source/en/model_doc/mbart.md
Comment thread docs/source/en/model_doc/mbart.md
Comment thread docs/source/en/model_doc/mbart.md Outdated
Comment thread docs/source/en/model_doc/mbart.md Outdated
@Vishesh-Mistry Vishesh-Mistry requested a review from stevhliu April 19, 2025 17:15
Vishesh-Mistry
Vishesh-Mistry commented Apr 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@Vishesh-Mistry Vishesh-Mistry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes have been addressed except the one regarding command-line usage. Let me know if you'd like me to include that as well

stevhliu
stevhliu reviewed Apr 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few more changes and we should be ready to merge! 🤗

Comment thread docs/source/en/model_doc/mbart.md Outdated
Comment thread docs/source/en/model_doc/mbart.md Outdated
tokenizer.batch_decode(generated_tokens, skip_special_tokens=True)
```

## Documentation resources
Copy link
Copy Markdown
Member

@stevhliu stevhliu Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove this section

Copy link
Copy Markdown
Contributor Author

@Vishesh-Mistry Vishesh-Mistry Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed these lines of code.

Copy link
Copy Markdown
Member

@stevhliu stevhliu Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I wasn't clear! The code example is fine the way it was before, but we can remove the ## Documentation resources section.

Copy link
Copy Markdown
Contributor Author

@Vishesh-Mistry Vishesh-Mistry Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have made the said changes

@Vishesh-Mistry
Copy link
Copy Markdown
Contributor Author

Vishesh-Mistry commented Apr 21, 2025

I have made all the said changes, please let me know if there are any other changes.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Apr 21, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu force-pushed the update-mbart-model-card branch from 19837a9 to e7cf39e Compare April 22, 2025 19:04
stevhliu
stevhliu approved these changes Apr 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤗

@stevhliu stevhliu merged commit 1d9743e into huggingface:main Apr 22, 2025
10 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@Vishesh-Mistry @stevhliu @zucchini-nlp
Updated model card for mbart and mbart50 (huggingface#37619)
6a38659 
* new card for mbart and mbart50

* removed comment BADGES

* Update mBart overview

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* fix typo (MBart to mBart)

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* maybe fix typo

* update typo and combine notes

* changed notes

* changed the example sentence

* fixed grammatical error and removed some lines from notes example

* missed one word

* removed documentation resources and added some lines of example code back in notes.

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vishesh-Mistry @HuggingFaceDocBuilderDev @stevhliu