Skip to content

Update granite.md#37791

Merged
stevhliu merged 23 commits intohuggingface:mainfrom
tanuj-rai:update-granite-model-card
May 27, 2025
Merged

Update granite.md#37791
stevhliu merged 23 commits intohuggingface:mainfrom
tanuj-rai:update-granite-model-card

Conversation

@tanuj-rai
Copy link
Copy Markdown
Contributor

@tanuj-rai tanuj-rai commented Apr 25, 2025

What does this PR do?

#36979,
This PR updates the model-card for the Granite model as described in #36979,

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@stevhliu

@github-actions github-actions Bot marked this pull request as draft April 25, 2025 15:37
@github-actions
Copy link
Copy Markdown
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Comment thread docs/source/en/model_doc/granite.md Outdated
Comment thread docs/source/en/model_doc/granite.md Outdated
Comment thread docs/source/en/model_doc/granite.md Outdated
Comment thread docs/source/en/model_doc/granite.md Outdated
Comment thread docs/source/en/model_doc/granite.md
Comment thread docs/source/en/model_doc/granite.md
Comment thread docs/source/en/model_doc/granite.md
Comment thread docs/source/en/model_doc/granite.md
Comment thread docs/source/en/model_doc/granite.md
Comment thread docs/source/en/model_doc/granite.md Outdated
tanuj-rai and others added 5 commits April 26, 2025 16:11
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@tanuj-rai
Copy link
Copy Markdown
Contributor Author

Hey @stevhliu, I’ve made the changes you suggested. Could you please review them and let me know if any further improvements are needed?

@stevhliu
Copy link
Copy Markdown
Member

Hey, there are still some unresolved comments!

@tanuj-rai
Copy link
Copy Markdown
Contributor Author

@stevhliu I've addressed all the comments. Please check to see if there's anything else that needs to be done.

Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, still a few unresolved comments and need to update the transformers cli section

Comment thread docs/source/en/model_doc/granite.md Outdated
Comment thread docs/source/en/model_doc/granite.md Outdated
Comment thread docs/source/en/model_doc/granite.md
Comment thread docs/source/en/model_doc/granite.md Outdated
Comment thread docs/source/en/model_doc/granite.md
Comment thread docs/source/en/model_doc/granite.md Outdated
tanuj-rai and others added 9 commits May 22, 2025 11:20
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@tanuj-rai
Copy link
Copy Markdown
Contributor Author

Thank you @stevhliu, for reviewing and suggesting changes. I have committed them. Could you please take a look at it?

Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to mark as ready and we can merge :)

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tanuj-rai tanuj-rai marked this pull request as ready for review May 24, 2025 02:09
@stevhliu
Copy link
Copy Markdown
Member

Can you push an empty commit to trigger the run_tests CI test?

@stevhliu stevhliu merged commit a092f6b into huggingface:main May 27, 2025
10 checks passed
@tanuj-rai
Copy link
Copy Markdown
Contributor Author

Thank you so much @stevhliu for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants