Skip to content

Superpoint fast image processor#37804

Merged
yonigozlan merged 28 commits intohuggingface:mainfrom
arkhamHack:superpoint_fast
Jul 28, 2025
Merged

Superpoint fast image processor#37804
yonigozlan merged 28 commits intohuggingface:mainfrom
arkhamHack:superpoint_fast

Conversation

@arkhamHack
Copy link
Copy Markdown
Contributor

@arkhamHack arkhamHack commented Apr 26, 2025 •
edited
Loading

What does this PR do?

Fixes #36978

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions Bot marked this pull request as draft April 26, 2025 13:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@arkhamHack arkhamHack marked this pull request as ready for review April 26, 2025 15:40
@github-actions github-actions Bot requested review from ydshieh and yonigozlan April 26, 2025 15:40
@arkhamHack
Copy link
Copy Markdown
Contributor Author

arkhamHack commented Apr 26, 2025

cc @yonigozlan

@yonigozlan yonigozlan mentioned this pull request Apr 23, 2025
Closed
81 tasks
yonigozlan
yonigozlan reviewed May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arkhamHack ! Thanks for opening this PR, looks good but a few things to change!
Also don't forget to rebase/merge with main, and remove any changes to dummy_torchvision_objects.py and src/transformers/__init__.py. Thanks!

Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
Comment thread src/transformers/models/superpoint/image_processing_superpoint_fast.py Outdated
@arkhamHack
Copy link
Copy Markdown
Contributor Author

arkhamHack commented Jun 23, 2025

@yonigozlan sorry for the delay. I have made the changes you requested for. Can you pls check the pr now?

@arkhamHack arkhamHack requested a review from yonigozlan June 23, 2025 09:23
yonigozlan
yonigozlan approved these changes Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arkhamHack for your contribution! Finished up the PR as we're trying to get all fast image processors merged asap.
Waiting for the CI to pass then LGTM!

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Jul 25, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yonigozlan yonigozlan enabled auto-merge (squash) July 25, 2025 18:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 28, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto, superpoint

@yonigozlan yonigozlan merged commit c353f2b into huggingface:main Jul 28, 2025
25 checks passed
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@arkhamHack @yonigozlan @zaristei
Superpoint fast image processor (huggingface#37804)
00f8e73 
* feat: superpoint fast image processor

* fix: reran fast cli command to generate fast config

* feat: updated test cases

* fix: removed old model add

* fix: format fix

* Update src/transformers/models/superpoint/image_processing_superpoint_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* fix: ported to torch and made requested changes

* fix: removed changes to init

* fix: init fix

* fix: init format fix

* fixed testcases and ported to torch

* fix: format fixes

* failed
test case fix

* fix superpoint fast

* fix docstring

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@arkhamHack @yonigozlan @zaristei
Superpoint fast image processor (huggingface#37804)
574e40d 
* feat: superpoint fast image processor

* fix: reran fast cli command to generate fast config

* feat: updated test cases

* fix: removed old model add

* fix: format fix

* Update src/transformers/models/superpoint/image_processing_superpoint_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* fix: ported to torch and made requested changes

* fix: removed changes to init

* fix: init fix

* fix: init format fix

* fixed testcases and ported to torch

* fix: format fixes

* failed
test case fix

* fix superpoint fast

* fix docstring

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@arkhamHack @yonigozlan @zaristei
Superpoint fast image processor (huggingface#37804)
d9e8fc3 
* feat: superpoint fast image processor

* fix: reran fast cli command to generate fast config

* feat: updated test cases

* fix: removed old model add

* fix: format fix

* Update src/transformers/models/superpoint/image_processing_superpoint_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* fix: ported to torch and made requested changes

* fix: removed changes to init

* fix: init fix

* fix: init format fix

* fixed testcases and ported to torch

* fix: format fixes

* failed
test case fix

* fix superpoint fast

* fix docstring

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@arkhamHack @yonigozlan @zaristei
Superpoint fast image processor (huggingface#37804)
fde16ce 
* feat: superpoint fast image processor

* fix: reran fast cli command to generate fast config

* feat: updated test cases

* fix: removed old model add

* fix: format fix

* Update src/transformers/models/superpoint/image_processing_superpoint_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* fix: ported to torch and made requested changes

* fix: removed changes to init

* fix: init fix

* fix: init format fix

* fixed testcases and ported to torch

* fix: format fixes

* failed
test case fix

* fix superpoint fast

* fix docstring

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@arkhamHack @yonigozlan @zaristei
Superpoint fast image processor (huggingface#37804)
b829d28 
* feat: superpoint fast image processor

* fix: reran fast cli command to generate fast config

* feat: updated test cases

* fix: removed old model add

* fix: format fix

* Update src/transformers/models/superpoint/image_processing_superpoint_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* fix: ported to torch and made requested changes

* fix: removed changes to init

* fix: init fix

* fix: init format fix

* fixed testcases and ported to torch

* fix: format fixes

* failed
test case fix

* fix superpoint fast

* fix docstring

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@arkhamHack @yonigozlan @zaristei
Superpoint fast image processor (huggingface#37804)
79db166 
* feat: superpoint fast image processor

* fix: reran fast cli command to generate fast config

* feat: updated test cases

* fix: removed old model add

* fix: format fix

* Update src/transformers/models/superpoint/image_processing_superpoint_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* fix: ported to torch and made requested changes

* fix: removed changes to init

* fix: init fix

* fix: init format fix

* fixed testcases and ported to torch

* fix: format fixes

* failed
test case fix

* fix superpoint fast

* fix docstring

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@arkhamHack @yonigozlan @zaristei
Superpoint fast image processor (huggingface#37804)
c696691 
* feat: superpoint fast image processor

* fix: reran fast cli command to generate fast config

* feat: updated test cases

* fix: removed old model add

* fix: format fix

* Update src/transformers/models/superpoint/image_processing_superpoint_fast.py

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>

* fix: ported to torch and made requested changes

* fix: removed changes to init

* fix: init fix

* fix: init format fix

* fixed testcases and ported to torch

* fix: format fixes

* failed
test case fix

* fix superpoint fast

* fix docstring

---------

Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
snorkelopstesting2-coder pushed a commit to snorkel-marlin-repos/huggingface_transformers_pr_37804_03a17aec-6ec4-4b11-a151-fedd4f766eaf that referenced this pull request Oct 11, 2025
Superpoint fast image processor
bcda987 
Original PR #37804 by arkhamHack
Original: huggingface/transformers#37804
@snorkelopstesting2-coder snorkelopstesting2-coder mentioned this pull request Oct 11, 2025
Merged
snorkelopstesting2-coder added a commit to snorkel-marlin-repos/huggingface_transformers_pr_37804_03a17aec-6ec4-4b11-a151-fedd4f766eaf that referenced this pull request Oct 11, 2025
@snorkelopstesting2-coder
Merge pull request #1: Superpoint fast image processor
8acb1e3 
Merged from original PR #37804
Original: huggingface/transformers#37804
snorkelopstesting2-coder pushed a commit to snorkel-marlin-repos/huggingface_transformers_pr_37804_6d72f3b1-d2b0-4060-96a2-f134f83138f9 that referenced this pull request Oct 11, 2025
Superpoint fast image processor
d87a0ab 
Original PR #37804 by arkhamHack
Original: huggingface/transformers#37804
@snorkelopstesting2-coder snorkelopstesting2-coder mentioned this pull request Oct 11, 2025
Merged
snorkelopstesting2-coder added a commit to snorkel-marlin-repos/huggingface_transformers_pr_37804_6d72f3b1-d2b0-4060-96a2-f134f83138f9 that referenced this pull request Oct 11, 2025
@snorkelopstesting2-coder
Merge pull request #1: Superpoint fast image processor
1c31cae 
Merged from original PR #37804
Original: huggingface/transformers#37804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonigozlan yonigozlan yonigozlan approved these changes

@ydshieh ydshieh Awaiting requested review from ydshieh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Contributions Welcome] Add Fast Image Processors

3 participants

@arkhamHack @HuggingFaceDocBuilderDev @yonigozlan