Skip to content

fix DbrxModelTest::test_offloaded_cache_implementation_0_offloaded #37853

Closed
faaany wants to merge 1 commit intohuggingface:mainfrom
faaany:issue248
Closed

fix DbrxModelTest::test_offloaded_cache_implementation_0_offloaded #37853
faaany wants to merge 1 commit intohuggingface:mainfrom
faaany:issue248

Conversation

@faaany
Copy link
Copy Markdown
Contributor

@faaany faaany commented Apr 29, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@Rocketknight1
Copy link
Copy Markdown
Member

cc @gante @IlyasMoutawwakil - @faaany can you explain the issue that requires this?

@gante
Copy link
Copy Markdown
Contributor

gante commented Apr 30, 2025

Hey 👋

This test was deleted in #37724, so there is no need to fix it 🤗 Recent PR that might be relevant to you @faaany : #37873

(I also noticed that overwrites of the deleted test were not deleted -- #37896 deletes them @Rocketknight1 )

@faaany
Copy link
Copy Markdown
Contributor Author

faaany commented May 6, 2025

great, thanks!

@faaany faaany closed this May 6, 2025
@faaany
Copy link
Copy Markdown
Contributor Author

faaany commented May 6, 2025

close as the test was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants