Skip to content

[Pipelines] Clean pipelines test and remove unnecessary code#3795

Merged
LysandreJik merged 1 commit intohuggingface:masterfrom
patrickvonplaten:remove_unused_inputs_for_model
Apr 16, 2020
Merged

[Pipelines] Clean pipelines test and remove unnecessary code#3795
LysandreJik merged 1 commit intohuggingface:masterfrom
patrickvonplaten:remove_unused_inputs_for_model

Conversation

@patrickvonplaten
Copy link
Copy Markdown
Contributor

@patrickvonplaten patrickvonplaten commented Apr 14, 2020

This PR cleans up pipelines a bit:

  1. Fixes non-working pipeline creation test
  2. Remove unnecessary code (due to PR Skipping outputs #3116) in pipelines as discussed with @thomwolf in PR Add t5 to pipeline(task='summarization') #3413

Note: Tested on QA pipelines slow tests.

@julien-c julien-c self-requested a review April 15, 2020 12:41
Copy link
Copy Markdown
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@LysandreJik LysandreJik merged commit baca8fa into huggingface:master Apr 16, 2020
@patrickvonplaten patrickvonplaten deleted the remove_unused_inputs_for_model branch April 16, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants