Conversation
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
commented
May 13, 2025
Comment on lines
+570
to
+578
| if isinstance(test_case, type): | ||
| for attr_name in dir(test_case): | ||
| attr = getattr(test_case, attr_name) | ||
| if isinstance(attr, types.FunctionType): | ||
| if getattr(attr, "__require_read_token__", False): | ||
| continue | ||
| wrapped = require_read_token(attr) | ||
| setattr(test_case, attr_name, wrapped) | ||
| return test_case |
Collaborator
Author
There was a problem hiding this comment.
Here dealing with class cases.
It will decorate all of its methods and return itself (TestCase).
ydshieh
commented
May 13, 2025
Comment on lines
+580
to
+594
| if getattr(test_case, "__require_read_token__", False): | ||
| return test_case | ||
|
|
||
| return _inner | ||
| @functools.wraps(test_case) | ||
| def wrapper(*args, **kwargs): | ||
| if token is not None: | ||
| with patch("huggingface_hub.utils._headers.get_token", return_value=token): | ||
| if "test_config" in str(test_case): | ||
| breakpoint() | ||
| return test_case(*args, **kwargs) | ||
| else: # Allow running locally with the default token env variable | ||
| return test_case(*args, **kwargs) | ||
|
|
||
| wrapper.__require_read_token__ = True | ||
| return wrapper |
Collaborator
Author
There was a problem hiding this comment.
Here for test method/function case
ydshieh
changed the title
require_read_token
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* update require_read_token * new repo * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
update
require_read_token.Currently, that decorator only works with function/method, but not for a class. The usage of it on classes will skip all the tests in those classes.
This PR fixes this issue.