Skip to content

[fix] Add FastSpeech2ConformerWithHifiGan#38207

Merged
stevhliu merged 9 commits intohuggingface:mainfrom
stevhliu:audio-fix
Jun 27, 2025
Merged

[fix] Add FastSpeech2ConformerWithHifiGan#38207
stevhliu merged 9 commits intohuggingface:mainfrom
stevhliu:audio-fix

Conversation

@stevhliu
Copy link
Copy Markdown
Member

Implements fix in this comment to enable FastSpeech2ConformerWithHiFiGan

@stevhliu stevhliu requested a review from eustlb May 19, 2025 15:48
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Contributor

@eustlb eustlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤗

@stevhliu
Copy link
Copy Markdown
Member Author

Is it ok to merge despite the failing test? The error seems to come from fastspeech2_conformer_with_hifigan not being defined in CONFIG_MAPPING_NAMES, but when I try adding it there, a ton of other tests fail as well 😅

@stevhliu stevhliu merged commit 02a769b into huggingface:main Jun 27, 2025
20 checks passed
@stevhliu stevhliu deleted the audio-fix branch June 27, 2025 16:38
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* add to mapping

* oops

* oops

* add to config_mapping_names

* revert

* fix?

* config-mapping-names

* fix?

* fix?
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* add to mapping

* oops

* oops

* add to config_mapping_names

* revert

* fix?

* config-mapping-names

* fix?

* fix?
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* add to mapping

* oops

* oops

* add to config_mapping_names

* revert

* fix?

* config-mapping-names

* fix?

* fix?
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* add to mapping

* oops

* oops

* add to config_mapping_names

* revert

* fix?

* config-mapping-names

* fix?

* fix?
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* add to mapping

* oops

* oops

* add to config_mapping_names

* revert

* fix?

* config-mapping-names

* fix?

* fix?
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* add to mapping

* oops

* oops

* add to config_mapping_names

* revert

* fix?

* config-mapping-names

* fix?

* fix?
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* add to mapping

* oops

* oops

* add to config_mapping_names

* revert

* fix?

* config-mapping-names

* fix?

* fix?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants