Fix Qwen2.5-VL Video Processor#38366
Fix Qwen2.5-VL Video Processor#38366ArthurZucker merged 8 commits intohuggingface:mainfrom yeliudev:main
Conversation
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks for the fix! Yes, I've been seeing the issue with return_tensors for a while and had a bigger PR to refactor further.
The problem isn't specific for Qwen models, and needs to be fixed in video_processing_utils.py. Can you try to update the PR to fix all video processors from base class?
|
Thanks for your comment! I'm afraid that I have no idea how to fix it in |
|
@yeliudev since it is the only common kwarg and is not in # `return_tensors` is a common kwargs thus not in processing_utils.VideosKwargs
validate_kwargs(
captured_kwargs=kwargs.keys(),
valid_processor_keys=list(self.valid_kwargs.__annotations__.keys()) + ["return_tensors"],
) |
|
@zucchini-nlp Yes it works. Many thanks! |
ArthurZucker
left a comment
There was a problem hiding this comment.
Merging as test is unrelated! not super fan of adding the return_tensors like that but can be done afterwards
What does this PR do?
This PR fixes the bug in Qwen2_5_VLProcessor, which would consistently logging "Unused or unrecognized kwargs: fps, return_tensors." during training. This issue seems to be introduced in #35206.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.