[video utils] group and reorder by number of frames#38374
Merged
zucchini-nlp merged 1 commit intohuggingface:mainfrom May 27, 2025
Merged
[video utils] group and reorder by number of frames#38374zucchini-nlp merged 1 commit intohuggingface:mainfrom
zucchini-nlp merged 1 commit intohuggingface:mainfrom
Conversation
zucchini-nlp
added
the
for patch
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
May 26, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for the quick fix
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 28, 2025
ArthurZucker
added a commit
that referenced
this pull request
May 30, 2025
* make it go brrrr * date time * update * fix * up * uppp * up * no number i * udpate * fix * [paligemma] fix processor with suffix (#38365) fix pg processor * [video utils] group and reorder by number of frames (#38374) fix * Fix convert to original state dict for VLMs (#38385) * fix convert to original state dict * fix * lint * Update modeling_utils.py * update * warn * no verbose * fginal * ouft * style --------- Co-authored-by: Raushan Turganbay <raushan@huggingface.co> Co-authored-by: hoshi-hiyouga <hiyouga@buaa.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #38352. Though we cannot handle in transformers videos of different shapes (yet!), it seems to be failing for vLLM
This PR ensures that videos are grouped not only by frame size, but also number of frames. A small test added and is green for me locally