[chat template] return assistant mask in processors#38545
Merged
zucchini-nlp merged 9 commits intohuggingface:mainfrom Jul 18, 2025
Merged
[chat template] return assistant mask in processors#38545zucchini-nlp merged 9 commits intohuggingface:mainfrom
zucchini-nlp merged 9 commits intohuggingface:mainfrom
Conversation
zucchini-nlp
force-pushed
the
chat-template-assistant-mask
branch
from
7d3e2a9 to
61112a1
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
changed the title
Member
Author
|
Ready for review! |
zucchini-nlp
commented
Jun 12, 2025
Comment on lines
+1464
to
+1465
| is_tokenizers_fast = hasattr(self, "tokenizer") and self.tokenizer.__class__.__name__.endswith("Fast") | ||
|
|
Member
Author
There was a problem hiding this comment.
I see that tokenizer's never checks this, probably because all new LLMs support fast tokenizers. Though users can force set use_fast=False for some reasons and the error message in that case is not informative
Should I add the check on tokenizer's apply_chat_template as well, WDYT?
Rocketknight1
approved these changes
Jul 15, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Sorry for taking so long to get to this! The logic makes sense, but the use of bisect_left confused me for a bit. After staring at it for a while, though, I think it's valid.
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: csm, shieldgemma2 |
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 22, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* messed up the git history, squash commits * raise error if slow and refine tests * index was off by one * fix the test
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #38521. I checked with fast tokenizers' implementation of
word_to_charand saw no difference in the time taken, so I think this can be the permanent solutionOtherwise we can add in
BatchFeaturesupport forEncodingFastfeatures, though I don't think anyone needs them and I have never seen user requesting it