fix(attention_visualizer): add default value for image_seq_length#38577
Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom Jun 4, 2025
Merged
Conversation
Rocketknight1
approved these changes
Jun 4, 2025
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Yes, this looks like a clean fix to me. Thank you!
47b732c to
980b4c6
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
bvantuan
pushed a commit
to bvantuan/transformers
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a small bug in
attention_visualizer.pywhereimage_seq_lengthmay be used before assignment.🐛 Bug Description
Calling
visualize_attention_mask()triggers:UnboundLocalError: cannot access local variable 'image_seq_length' where it is not associated with a value
Fix
Just adds one line code
image_seq_length = None
Fixes #38576
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker