Standardize ByT5 model card format#38699
Merged
stevhliu merged 5 commits intohuggingface:mainfrom Jun 9, 2025
Merged
Conversation
stevhliu
reviewed
Jun 9, 2025
Contributor
Author
|
Thanks @stevhliu for the detailed feedback! I've updated the model card as suggested. Please let me know if anything else needs adjusting. |
stevhliu
approved these changes
Jun 9, 2025
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Just a few more comments and then we can merge :)
Contributor
Author
|
Everything's done now. Thanks again for your help :) |
stevhliu
force-pushed
the
update-byt5-model-card
branch
from
4582b1b to
9011011
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Can you try running |
* fix 1: load_in_4bit=True, * fix 2: decorateor * fixfix 2: breakpoint * fixfix 3: update * fixfix 4: fast * fixfix 5: cond * fixfix 5: cond * fixfix 6: cuda 8 * ruff * breakpoint * dtype * a10 * a10 --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Contributor
Author
|
I've rebased the branch to bring it up to date and pushed the fix for the repo check error. Please let me know if it's all good now :) |
bvantuan
pushed a commit
to bvantuan/transformers
that referenced
this pull request
Jun 12, 2025
* Standardize ByT5 model card format * Apply review feedback from @stevhliu * Fix Notes formatting and wording * Fix `aya_vision` test (huggingface#38674) * fix 1: load_in_4bit=True, * fix 2: decorateor * fixfix 2: breakpoint * fixfix 3: update * fixfix 4: fast * fixfix 5: cond * fixfix 5: cond * fixfix 6: cuda 8 * ruff * breakpoint * dtype * a10 * a10 --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> * Fix autodoc formatting for ByT5Tokenizer --------- Co-authored-by: Yih-Dar <2521628+ydshieh@users.noreply.github.com> Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the ByT5 model card to follow the standardized format as requested in #36979.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@stevhliu