LlamaAttention forward function type hint is incorrect from new Branch #38998
Merged
qubvel merged 7 commits intohuggingface:mainfrom Jul 1, 2025
ArkVex:main
Merged
LlamaAttention forward function type hint is incorrect from new Branch #38998qubvel merged 7 commits intohuggingface:mainfrom ArkVex:main
qubvel merged 7 commits intohuggingface:mainfrom
ArkVex:main
Conversation
Contributor
Author
@Rocketknight1 trying again |
Contributor
Author
|
I think I shall close the fork are refork it again |
Contributor
|
Hey @ArkVex, thanks for fixing typehints! To fix repo-cosistency issue can you please run the following command and commit the changes? |
Contributor
Author
|
@qubvel still throwing the same error |
Contributor
Author
|
Idk what is wrong in this...i did such minute change and it is troubling so much |
Contributor
|
@ArkVex, I hope you don't mind, I've applied the command above and pushed the changes |
qubvel
approved these changes
Jun 27, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
4 tasks
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* helo llama * helo llama * helo llama * apply modular * fix dia --------- Co-authored-by: qubvel <qubvel@gmail.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* helo llama * helo llama * helo llama * apply modular * fix dia --------- Co-authored-by: qubvel <qubvel@gmail.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* helo llama * helo llama * helo llama * apply modular * fix dia --------- Co-authored-by: qubvel <qubvel@gmail.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* helo llama * helo llama * helo llama * apply modular * fix dia --------- Co-authored-by: qubvel <qubvel@gmail.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* helo llama * helo llama * helo llama * apply modular * fix dia --------- Co-authored-by: qubvel <qubvel@gmail.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* helo llama * helo llama * helo llama * apply modular * fix dia --------- Co-authored-by: qubvel <qubvel@gmail.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* helo llama * helo llama * helo llama * apply modular * fix dia --------- Co-authored-by: qubvel <qubvel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes a small issue in the LlamaAttention class. The return type in the forward method currently shows three values, but the function actually returns only two. This seems to have been missed during the attention refactor (possibly in PR #35235).
I’ve updated the type hint to reflect the actual return values, just to avoid confusion for anyone reading or using the code. Let me know if any other changes are needed. Happy to help!