[bugfix] fix flash attention 2 unavailable error on Ascend NPU#39166
Merged
ArthurZucker merged 2 commits intohuggingface:mainfrom Jul 7, 2025
Merged
[bugfix] fix flash attention 2 unavailable error on Ascend NPU#39166ArthurZucker merged 2 commits intohuggingface:mainfrom
ArthurZucker merged 2 commits intohuggingface:mainfrom
Conversation
Contributor
Author
|
This PR is ready for merge @ArthurZucker @SunMarc, cc @EduardDurech |
Contributor
|
Thanks, I didn't have a device to test this on but looks like you did it correctly |
Contributor
Author
|
Looking forward for review @ArthurZucker @SunMarc |
ArthurZucker
approved these changes
Jul 7, 2025
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Makes sense, I think this deserves to be in the patch!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
pushed a commit
that referenced
this pull request
Jul 11, 2025
[bugfix] fix flash attention 2 error on Ascend NPU
SwiftAkira
pushed a commit
to SwiftAkira/transformers
that referenced
this pull request
Jul 11, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
Contributor
|
Very good work. Can Flash Attention 3 also be used on the Ascend NPU? |
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ngface#39166) [bugfix] fix flash attention 2 error on Ascend NPU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#38972 introduce flash attention 3 into
transformers. However, the modification introduce a bug when using flash attention 2 on Ascend NPU.The core reason is due to function names mismatch:
Functions defined from
transformers.integrations.npu_flash_attention:transformers/src/transformers/modeling_flash_attention_utils.py
Lines 140 to 153 in e8e0c76
Functions actually used:
transformers/src/transformers/modeling_flash_attention_utils.py
Lines 470 to 475 in e8e0c76
This PR is committed for solving this problem, by renaming flash attention 2 related functions (e.g.
npu_flash_attn_func) fromtransformers.integrations.npu_flash_attentionto correct names, which should contain_2_symbol (e.g.flash_attn_2_func)Fixes # (issue)
Not related.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.