Make _compute_dynamic_ntk_parameters exportable#39171
Merged
ArthurZucker merged 3 commits intohuggingface:mainfrom Jul 7, 2025
Merged
Make _compute_dynamic_ntk_parameters exportable#39171ArthurZucker merged 3 commits intohuggingface:mainfrom
ArthurZucker merged 3 commits intohuggingface:mainfrom
Conversation
ArthurZucker
approved these changes
Jul 7, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Very nice! Thanks for fixing
SwiftAkira
pushed a commit
to SwiftAkira/transformers
that referenced
this pull request
Jul 11, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Make _compute_dynamic_ntk_parameters exportable * add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Function
def _compute_dynamic_ntk_parametersis not exportable (with torch.export.export) due to a control flow, this PR rewrites it with torch.maximum.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.