[modular] Simplify logic and docstring handling#39185
Merged
Cyrilvallez merged 6 commits intomainfrom Jul 7, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
changed the title
Cyrilvallez
force-pushed
the
refine-modular
branch
from
35297d3 to
de6c065
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: d_fine, diffllama, dinov2_with_registers, emu3, falcon_h1, gemma, gemma2, gemma3, gemma3n, glm4v, helium, instructblipvideo, internvl, mlcd, sam_hq, smolvlm |
ArthurZucker
approved these changes
Jul 7, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Nice! thanks for fixing
SwiftAkira
pushed a commit
to SwiftAkira/transformers
that referenced
this pull request
Jul 11, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* simplify a lot * Update modular_model_converter.py * finalize * remove outdated functions * apply it * and examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplify a lot
replace_class_nodelogic (I wanted to do it from a long time ago as it was all bloated and super hard to read) and simplify the docstring handling at the same time.Basically, the idea is now to use the parent docstring if there are no docstrings, or to use the docstring in modular if any. Previously, we were doing some kind of merging between the 2 docstrings, which was bugged (see a few places in the diff where there are arg explanations after examples or similar issues), inconsistent (i.e. adding a simple arg for a Config, while convenient, was always inconsistent because the checkpoints link was never updated correctly) and surprising (this is some kind of magic that contributors were very rarely understanding (which makes sense at it had a lot of issues as explained). Moreover, with
auto_docstringnow, we should not have to redefine the parameters explanations everytime, so it makes sense to relax docstring handling.