Skip to content

fix fastspeech2_conformer tests#39229

Merged
ydshieh merged 4 commits intomainfrom
fix_fastspeech2_conformer
Jul 7, 2025
Merged

fix fastspeech2_conformer tests#39229
ydshieh merged 4 commits intomainfrom
fix_fastspeech2_conformer

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Jul 4, 2025

What does this PR do?

The 2 tests are failing for long time. I also need to update one expected output values

ydshieh
ydshieh commented Jul 4, 2025
View reviewed changes
Comment thread tests/models/fastspeech2_conformer/test_modeling_fastspeech2_conformer.py
[
[-9.6345e-04, 1.3557e-03, 5.7559e-04, 2.4706e-04, 2.2675e-04, 1.2258e-04, 4.7784e-04, 1.0109e-03, -1.9718e-04, 6.3495e-04, 3.2106e-04, 6.3620e-05, 9.1713e-04, -2.5664e-05, 1.9596e-04, 6.0418e-04, 8.1112e-04, 3.6342e-04, -6.3396e-04, -2.0146e-04, -1.1768e-04, 4.3155e-04, 7.5599e-04, -2.2972e-04, -9.5665e-05, 3.3078e-04, 1.3793e-04, -1.4932e-04, -3.9645e-04, 3.6473e-05, -1.7224e-04, -4.5370e-05, -4.8950e-04, -4.3059e-04, 1.0451e-04, -1.0485e-03, -6.0410e-04, 1.6990e-04, -2.1997e-04, -3.8769e-04, -7.6898e-04, -3.2372e-04, -1.9783e-04, 5.2896e-05, -1.0586e-03, -7.8516e-04, 7.6867e-04, -8.5331e-05, -4.8158e-04, -4.5362e-05, -1.0770e-04, 6.6823e-04, 3.0765e-04, 3.3669e-04, 9.5677e-04, 1.0458e-03, 5.8129e-04, 3.3737e-04, 1.0816e-03, 7.0346e-04, 4.2378e-04, 4.3131e-04, 2.8095e-04, 1.2201e-03, 5.6121e-04, -1.1086e-04, 4.9908e-04, 1.5586e-04, 4.2046e-04, -2.8088e-04, -2.2462e-04, -1.5539e-04, -7.0126e-04, -2.8577e-04, -3.3693e-04, -1.2471e-04, -6.9104e-04, -1.2867e-03, -6.2651e-04, -2.5586e-04, -1.3201e-04, -9.4537e-04, -4.8438e-04, 4.1458e-04, 6.4109e-04, 1.0891e-04, -6.3764e-04, 4.5573e-04, 8.2974e-04, 3.2973e-06, -3.8274e-04, -2.0400e-04, 4.9922e-04, 2.1508e-04, -1.1009e-04, -3.9763e-05, 3.0576e-04, 3.1485e-05, -2.7574e-05, 3.3856e-04],
],
[-9.6345e-04, 1.3557e-03, 5.7559e-04, 2.4706e-04, 2.2675e-04, 1.2258e-04, 4.7784e-04, 1.0109e-03, -1.9718e-04, 6.3495e-04, 3.2106e-04, 6.3620e-05, 9.1713e-04, -2.5664e-05, 1.9596e-04, 6.0418e-04, 8.1112e-04, 3.6342e-04, -6.3396e-04, -2.0146e-04, -1.1768e-04, 4.3155e-04, 7.5599e-04, -2.2972e-04, -9.5665e-05, 3.3078e-04, 1.3793e-04, -1.4932e-04, -3.9645e-04, 3.6473e-05, -1.7224e-04, -4.5370e-05, -4.8950e-04, -4.3059e-04, 1.0451e-04, -1.0485e-03, -6.0410e-04, 1.6990e-04, -2.1997e-04, -3.8769e-04, -7.6898e-04, -3.2372e-04, -1.9783e-04, 5.2896e-05, -1.0586e-03, -7.8516e-04, 7.6867e-04, -8.5331e-05, -4.8158e-04, -4.5362e-05, -1.0770e-04, 6.6823e-04, 3.0765e-04, 3.3669e-04, 9.5677e-04, 1.0458e-03, 5.8129e-04, 3.3737e-04, 1.0816e-03, 7.0346e-04, 4.2378e-04, 4.3131e-04, 2.8095e-04, 1.2201e-03, 5.6121e-04, -1.1086e-04, 4.9908e-04, 1.5586e-04, 4.2046e-04, -2.8088e-04, -2.2462e-04, -1.5539e-04, -7.0126e-04, -2.8577e-04, -3.3693e-04, -1.2471e-04, -6.9104e-04, -1.2867e-03, -6.2651e-04, -2.5586e-04, -1.3201e-04, -9.4537e-04, -4.8438e-04, 4.1458e-04, 6.4109e-04, 1.0891e-04, -6.3764e-04, 4.5573e-04, 8.2974e-04, 3.2973e-06, -3.8274e-04, -2.0400e-04, 4.9922e-04, 2.1508e-04, -1.1009e-04, -3.9763e-05, 3.0576e-04, 3.1485e-05, -2.7574e-05, 3.3856e-04],
Copy link
Copy Markdown
Collaborator Author

@ydshieh ydshieh Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value not changed, just remove the batch dimension.

ydshieh
ydshieh commented Jul 4, 2025
View reviewed changes
Comment thread tests/models/fastspeech2_conformer/test_modeling_fastspeech2_conformer.py
Comment on lines +454 to +463
[-5.1726e-01, -2.1546e-01, -6.2949e-01, -4.9966e-01, -6.2329e-01,-1.0024e+00, -5.0756e-01, -4.3783e-01, -7.7909e-01, -7.1529e-01],
[3.1639e-01, 4.6567e-01, 2.3859e-01, 6.1324e-01, 6.6993e-01,2.7852e-01, 3.4084e-01, 2.6045e-01, 3.1769e-01, 6.8664e-01],
[1.0904e+00, 8.2760e-01, 5.4471e-01, 1.3948e+00, 1.2052e+00,1.3914e-01, 3.0311e-01, 2.9209e-01, 6.6969e-01, 1.4900e+00],
[8.7539e-01, 7.7813e-01, 8.5193e-01, 1.7797e+00, 1.5827e+00,2.1765e-01, 9.5736e-02, 1.5207e-01, 9.2984e-01, 1.9718e+00],
[1.0156e+00, 7.4948e-01, 8.5781e-01, 2.0302e+00, 1.8718e+00,-4.6816e-02, -8.4771e-02, 1.5288e-01, 9.6214e-01, 2.1747e+00],
[9.5446e-01, 7.2816e-01, 8.5703e-01, 2.1049e+00, 2.1529e+00,9.1168e-02, -1.8864e-01, 4.7460e-02, 9.1671e-01, 2.2506e+00],
[1.0980e+00, 6.5521e-01, 8.2278e-01, 2.1420e+00, 2.2990e+00,1.1589e-01, -2.2167e-01, 1.1425e-03, 8.5591e-01, 2.2267e+00],
[9.2134e-01, 6.2354e-01, 8.9153e-01, 2.1447e+00, 2.2947e+00,9.8064e-02, -1.3171e-01, 1.2306e-01, 9.6330e-01, 2.2747e+00],
[1.0625e+00, 6.4575e-01, 1.0348e+00, 2.0821e+00, 2.1834e+00,2.3807e-01, -1.3262e-01, 1.5632e-01, 1.1988e+00, 2.3948e+00],
[1.4111e+00, 7.5421e-01, 1.0703e+00, 2.0512e+00, 1.9331e+00,4.0482e-03, -4.2486e-02, 4.6495e-01, 1.4404e+00, 2.3599e+00],
Copy link
Copy Markdown
Collaborator Author

@ydshieh ydshieh Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, this test fails for long time.

@ydshieh ydshieh requested a review from eustlb July 4, 2025 16:16
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Jul 4, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

eustlb
eustlb approved these changes Jul 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eustlb eustlb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again it would have been so helpful to have self-contained reproducer for the integration tests expected outputs (cf here), a good practice that we should encourage a bit more IMO (cc @ArthurZucker).
Here I guess it's okay to merge with such values, issues would have been raised anyway if these long failing test reflected a model failure.

@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented Jul 7, 2025

self-contained reproducer for the integration tests expected outputs

May I know why such reproducer script is preferred over the test itself?

@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented Jul 7, 2025

run-slow: fastspeech2_conformer

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 7, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: fastspeech2_conformer

@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented Jul 7, 2025

run-slow: fastspeech2_conformer

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 7, 2025

This comment contains run-slow, running the specified jobs:

models: ['models/fastspeech2_conformer']
quantizations: [] ...

@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented Jul 7, 2025

Merge (the failing slow CI is only multi-gpu related)

@ydshieh ydshieh merged commit 9b09fe4 into main Jul 7, 2025
20 of 21 checks passed
@ydshieh ydshieh deleted the fix_fastspeech2_conformer branch July 7, 2025 13:04
SwiftAkira pushed a commit to SwiftAkira/transformers that referenced this pull request Jul 11, 2025
@ydshieh @SwiftAkira
fix fastspeech2_conformer tests (huggingface#39229)
9067d42 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
rjgleaton pushed a commit to rjgleaton/transformers that referenced this pull request Jul 17, 2025
@ydshieh @rjgleaton
fix fastspeech2_conformer tests (huggingface#39229)
2d4698e 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@ydshieh @zaristei
fix fastspeech2_conformer tests (huggingface#39229)
b8a10dc 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@ydshieh @zaristei
fix fastspeech2_conformer tests (huggingface#39229)
a35b8f3 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@ydshieh @zaristei
fix fastspeech2_conformer tests (huggingface#39229)
7d5480a 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@ydshieh @zaristei
fix fastspeech2_conformer tests (huggingface#39229)
a75cc7a 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@ydshieh @zaristei
fix fastspeech2_conformer tests (huggingface#39229)
eacae88 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@ydshieh @zaristei
fix fastspeech2_conformer tests (huggingface#39229)
33d7d18 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
@ydshieh @zaristei
fix fastspeech2_conformer tests (huggingface#39229)
75c2428 
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eustlb eustlb eustlb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ydshieh @HuggingFaceDocBuilderDev @eustlb