Add a default value for position_ids in masking_utils#39310
Merged
Cyrilvallez merged 3 commits intomainfrom Jul 10, 2025
Merged
Add a default value for position_ids in masking_utils#39310Cyrilvallez merged 3 commits intomainfrom
position_ids in masking_utils#39310Cyrilvallez merged 3 commits intomainfrom
Conversation
Cyrilvallez
added
the
for patch
BenjaminBossan
approved these changes
Jul 9, 2025
Member
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
The change to find_packed_sequence_indices and the test are unrelated, are they?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Jul 9, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Can you add the test that was reported to fail as well?
Member
Author
|
Indeed, the added test is unrelated, I just forgot to add on the previous PR. There are no failed tests on Transformers, issue was highlighted on the |
Cyrilvallez
added a commit
that referenced
this pull request
Jul 11, 2025
* set default * Update masking_utils.py * add small test
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
…39310) * set default * Update masking_utils.py * add small test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…39310) * set default * Update masking_utils.py * add small test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…39310) * set default * Update masking_utils.py * add small test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…39310) * set default * Update masking_utils.py * add small test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…39310) * set default * Update masking_utils.py * add small test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…39310) * set default * Update masking_utils.py * add small test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…39310) * set default * Update masking_utils.py * add small test
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…39310) * set default * Update masking_utils.py * add small test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. See related discussion in #39194
Also cc @BenjaminBossan, sorry again for the inconvenience on this one!