Skip to content

fix phi3 tests#39312

Merged
ydshieh merged 1 commit intomainfrom
fix_phi3
Jul 10, 2025
Merged

fix phi3 tests#39312
ydshieh merged 1 commit intomainfrom
fix_phi3

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Jul 9, 2025

What does this PR do?

These 2 tests are never passing after (#31436) , as we didn't update the expected outputs after

Rename Phi-3 rope scaling type (#31436)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 9, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: phi3

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's been a year since the renaming 🤯

I'm surprised that 4K checkpoint was affected, afaik it uses no scaling. At this point there were more PRs that affected expected outputs, guess it's fine

@ydshieh ydshieh merged commit 92043bd into main Jul 10, 2025
20 checks passed
@ydshieh ydshieh deleted the fix_phi3 branch July 10, 2025 09:51
rjgleaton pushed a commit to rjgleaton/transformers that referenced this pull request Jul 17, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants