Fix typing order

[Tavish9]

What does this PR do?

• This PR fix the typing order change by No more Tuple, List, Dict #38797

Fixes #39462

Importing order matters
Before #38797, Union[str, Dict] was okay for type Union[dict, str].
When changing from Dict from dict, Union[str, dict] would predominate Union[dict, str] if it's imported early than TrainingArguments.

Before submitting

• This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
• Did you read the contributor guideline,
  Pull Request section?
• Was this discussed/approved via a Github issue or the forum? Please add a link
  to it if that's the case.
• Did you make sure to update the documentation with your changes? Here are the
  documentation guidelines, and
  here are tips on formatting docstrings.
• Did you write any new necessary tests?

Who can review?

@zach-huggingface, @SunMarc and @qgallouedec

[SunMarc]

Thanks for fixing this ! Can you add a test to check the HfArgumentParser so that this doesn't happen ? Also, let's replace union[str, dict] to union[dict, str] in the codebase

[Tavish9]

Hi, I want to add tests, but as I said, Importing order matters, I cannot test by importing every file in the repo.

Commonly used files: Trainer, PreTrainedModel, AutoModel etc... (too many)

What's your opinion here for the test?

[SunMarc]

Let's just restrict ourselves to the most used files like Trainer, AutoModel in the first place and we can potentially add more in the future.

[Tavish9]

Already done.

I fix the order in the test and we don't need to test importing every module.

Before:

After:

[SunMarc]

Thanks !

[Tavish9]

Wait, I found the tests are skipped

SKIPPED [1] tests/utils/test_hf_argparser.py:487: test requires deepspeed

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[Tavish9]

Replace deepspeed with accelerator to not be skipped :)

[github-actions]

[For maintainers] Suggested jobs to run (before merge)

run-slow: modernbert