Add Fast Image Processor for ImageGPT#39592
Conversation
|
cc @yonigozlan |
…astImageProcessorKwargs
…om BaseImageProcessorFast
|
Hey @agamjots05 and @ayaayethan ! Thanks for opening this PR, don't hesitate to ping me when it's ready to review or if you need help! |
Thank you for letting us know! We'll let you know if we get stuck on anything 👍 |
…ass in the test file to test fast processor
|
@yonigozlan Quick question To get the final two slow/fast parity tests to pass, we needed to make two very small changes in the slow ImageGPTImageProcessor:
Would these two minimal adjustments to the slow processor be acceptable? |
|
Hey @agamjots05 ! |
Sounds good. If that's the case, then this PR should be ready for review 👍 |
yonigozlan
left a comment
There was a problem hiding this comment.
Hey @agamjots05 and @ayaayethan , thanks for contributing! There's a few changes to do, and I'll be off for two weeks, but happy to do another review when I'm back!
|
@yonigozlan I believe I have implemented all the changes you have requested. Please take a look when you can 👍 |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, imagegpt |
yonigozlan
left a comment
There was a problem hiding this comment.
Thanks for working on this @agamjots05 and @ayaayethan !
I just pushed some small simplifications to the color quantize logic, and I'll merge once the CI passes!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Original PR #39592 by agamjots05 Original: huggingface/transformers#39592
Merged from original PR #39592 Original: huggingface/transformers#39592
Original PR #39592 by agamjots05 Original: huggingface/transformers#39592
Merged from original PR #39592 Original: huggingface/transformers#39592
What does this PR do?
Related #36978
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.