revert behavior of _prepare_from_posids#39622
Merged
ArthurZucker merged 2 commits intohuggingface:mainfrom Jul 24, 2025
Merged
Conversation
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks, this won't work for inference! can we just have a if else!
Collaborator
|
(Thanks a lot for checking sorry for breaking) |
ArthurZucker
approved these changes
Jul 24, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks makes sense!
5 tasks
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#39474 causes the grad norm to become NaN during training. We don't need to revert the whole thing, but reverting just this function seems to fix the regression.
@ArthurZucker @SunMarc
pre-#39474 loss
post-#39474 loss
with this fix
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.