properly save model across tensor parallel processes#39700
Closed
winglian wants to merge 2 commits intohuggingface:mainfrom
Closed
properly save model across tensor parallel processes#39700winglian wants to merge 2 commits intohuggingface:mainfrom
winglian wants to merge 2 commits intohuggingface:mainfrom
Conversation
ArthurZucker
added
the
for patch
Contributor
|
Superseeded by #39693 |
S1ro1
removed
the
for patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tensor Parallel saving doesn't work because currently it would use the default of checking args.should_save which would only save on rank0, but we need to coordinate across TP ranks to gather the dtensors.
This is still in draft as I need to solve for FSDP + TP too.
@S1ro1
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.