Fix responses add tests#39848
Merged
LysandreJik merged 5 commits intomainfrom Aug 1, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
approved these changes
Aug 1, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
lgtm, thank you for fixing 🙏
Contributor
|
@LysandreJik I think our CI doesn't like the current integration tests for |
Member
Author
|
It's my bad I put as fast tests which shouldn't be, I'm putting them back as slow; this should get the CI green, and I'll check why the threads seem to not exit down the road |
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Quick responses fix * [serve] Fix responses API and add tests * Remove typo * Remove typo * Tests
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Quick responses fix * [serve] Fix responses API and add tests * Remove typo * Remove typo * Tests
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Quick responses fix * [serve] Fix responses API and add tests * Remove typo * Remove typo * Tests
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Quick responses fix * [serve] Fix responses API and add tests * Remove typo * Remove typo * Tests
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Quick responses fix * [serve] Fix responses API and add tests * Remove typo * Remove typo * Tests
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Quick responses fix * [serve] Fix responses API and add tests * Remove typo * Remove typo * Tests
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* Quick responses fix * [serve] Fix responses API and add tests * Remove typo * Remove typo * Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the
/v1/responsessupport in transformers serve to:transformers serveaccept a default seed at startup, enables better integration testingWe also add tests for the Responses API, with an end-to-end test.