fix: Add einops as a core dependency#39892
Closed
Hashbrownsss wants to merge 1 commit intohuggingface:mainfrom
Closed
fix: Add einops as a core dependency#39892Hashbrownsss wants to merge 1 commit intohuggingface:mainfrom
Hashbrownsss wants to merge 1 commit intohuggingface:mainfrom
Conversation
ArthurZucker
reviewed
Aug 4, 2025
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks! Tho I think this should be added to the npu extra instead!
cd473fb to
8c11f1b
Compare
Author
|
Hey! Thanks for the quick feedback. Although i couldnt find a dedicated npu extra. ive updated the PR to add einops to dev-torch instead, as it seems like the most apt place for the dependency I hope that works! |
Contributor
|
It seems like the einops dependency is only due to the un-/padding functions. It would be best to just rewrite them with normal torch and/or use the fa3 equivalents in the fa modeling utils file - no need for the einops dependency. |
Contributor
|
#40002 will probably remove the einops dependency but will keep you updated if not |
Author
|
That sounds good! I'll close this PR and keep an eye on #40002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses the
ModuleNotFoundErrorfor theeinopslibrary by adding it as a core dependency.It fixes issue #39811, where certain parts of the
transformerslibrary, specifically in the flash attention code, were trying to importeinopswithout it being a declared dependency. This bug prevented users from successfully running models that rely on this library.By adding
einopstosetup.py, this PR ensures that the library is automatically installed for all users, making thetransformerspackage more robust and reliable.Fixes #39811
Before submitting
Pull Request section?
to it if that's the case. This PR fixes issue Missing einops dependency causing ModuleNotFoundError #39811.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker
@ivarflakstad
@iforgetmyname