[Idefics] fix device mismatch#39981
Merged
zucchini-nlp merged 1 commit intohuggingface:mainfrom Aug 7, 2025
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: idefics2, idefics3, smolvlm |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
approved these changes
Aug 7, 2025
zucchini-nlp
added
the
for patch
4 tasks
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 13, 2025
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Aug 15, 2025
There is a bug in 4.55.0 in the Idefics model, which was fixed by huggingface/transformers#39981 MODULAR_ORIG_COMMIT_REV_ID: 79384a5cc36b6136bd337e74e4417a70b9786a11
5 tasks
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Dec 9, 2025
There is a bug in 4.55.0 in the Idefics model, which was fixed by huggingface/transformers#39981 MAX_INTEGRATION_TESTS_REV_ID: 79384a5cc36b6136bd337e74e4417a70b9786a11
lriggs1311
pushed a commit
to modular/modular
that referenced
this pull request
Dec 9, 2025
There is a bug in 4.55.0 in the Idefics model, which was fixed by huggingface/transformers#39981 MAX_INTEGRATION_TESTS_REV_ID: 79384a5cc36b6136bd337e74e4417a70b9786a11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #39947. We need to use consistent device when computing
position_ids, and since we are updatingposition_idswe will use its device instead ofpixel_values. Otherwise it raises errors because those are located in two different devices