chore: Add type hints to import_utils.py module#39994
chore: Add type hints to import_utils.py module#39994wirthual wants to merge 11 commits intohuggingface:mainfrom
Conversation
|
Failed image download reason for test failure. See #40000 |
|
Very confused about why the tests are failing - it seems to consistently be the |
|
@Rocketknight1 The job (of scheduled daily CI) running But other CircleCI runs also failing this test? OK, it does fail when I run it, even with several previous commits. Can ignore it in this PR as unrelated. I will check |
|
actually, it starts to show up on circleci since (@Rocketknight1 ) but there is no 3rd party lib changes compared to the run just before it ... |
|
ok, unrelated warning maybe {message : DeprecationWarning('builtin type SwigPyPacked has no module attribute'), category : 'DeprecationWarning', filename : '', lineno : 241, line : None} |
|
i'm not sure why this tests continues to fail on this PR but not on all PRs . |
|
Also not sure. I opened a new one as a test here: #40319 If that does not work I can also start the process from the start to make sure it works. |
|
Closing since we've merged #40319, and thank you for the PR! |
What does this PR do?
Add type hints to
import_utils.pyBased on these docs, this change should avoid errors like:
Before submitting
Pull Request section?
Who can review?
@stevhliu