Skip to content

Fix missing None default values for Gemma3n model in get_placeholder_mask (#39991)#40024

Merged
zucchini-nlp merged 2 commits intohuggingface:mainfrom
Znerual:main
Aug 8, 2025
Merged

Fix missing None default values for Gemma3n model in get_placeholder_mask (#39991)#40024
zucchini-nlp merged 2 commits intohuggingface:mainfrom
Znerual:main

Conversation

@Znerual
Copy link
Copy Markdown
Contributor

@Znerual Znerual commented Aug 8, 2025 •
edited
Loading

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma3n

zucchini-nlp
zucchini-nlp approved these changes Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, can you make sure the CI passes?

@zucchini-nlp
Copy link
Copy Markdown
Member

zucchini-nlp commented Aug 8, 2025

run-slow: gemma3n

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2025

This comment contains run-slow, running the specified jobs:

models: ['models/gemma3n']
quantizations: [] ...

@Znerual
Copy link
Copy Markdown
Contributor Author

Znerual commented Aug 8, 2025

Sure! Happy to help. I fixed the CLI issues

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) August 8, 2025 10:31
@zucchini-nlp zucchini-nlp merged commit 95510ab into huggingface:main Aug 8, 2025
18 checks passed
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Aug 8, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp zucchini-nlp added the for patch Tag issues / labels that should be included in the next patch label Aug 8, 2025
@Kuangdd01 Kuangdd01 mentioned this pull request Aug 12, 2025
Closed
1 task
ArthurZucker pushed a commit that referenced this pull request Aug 13, 2025
@Znerual @Laurenz-Ruzicka @ArthurZucker
Fix missing None default values for Gemma3n model in get_placeholder_…
586b6e6 
…mask (#39991) (#40024)

* Fix missing None default values for Gemma3n model in get_placeholder_mask (#39991)

* Switched definition of optional from| None to Optiona[] (Issue #39991)

---------

Co-authored-by: Laurenz Ruzicka <Laurenz.Ruzicka@ait.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zucchini-nlp zucchini-nlp zucchini-nlp approved these changes

Assignees

No one assigned

Labels

for patch Tag issues / labels that should be included in the next patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Znerual @zucchini-nlp @HuggingFaceDocBuilderDev @Laurenz-Ruzicka