Fix: catch requests.ConnectionError in list_repo_templates#40158
Closed
laitifranz wants to merge 1 commit intohuggingface:mainfrom
laitifranz:fix/handle-requests-connection-error-in-list-repo-templates
Closed
Fix: catch requests.ConnectionError in list_repo_templates#40158laitifranz wants to merge 1 commit intohuggingface:mainfrom laitifranz:fix/handle-requests-connection-error-in-list-repo-templates
laitifranz wants to merge 1 commit intohuggingface:mainfrom
laitifranz:fix/handle-requests-connection-error-in-list-repo-templates
Conversation
Member
|
We have a PR for this already! #39874 |
Author
|
Thanks for pointing that out and for merging the fix recently! I’ll close this PR in favor of #39874 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in the
list_repo_templatesfunction where network connectivity issues would cause the entire function to crash instead of gracefully falling back to local files.Problem
When used without an internet connection, the function raised:
The exception handler only caught Python’s built-in
ConnectionError, not therequests-specific one, so the fallback logic never ran.Fix
Add
requests.exceptions.ConnectionErrorto the exception handler.Now, if the network is unavailable, the function correctly falls back to local cached templates as intended.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1