fix MetaCLIP 2 wrong link & wrong model names in the docstrings#40565
fix MetaCLIP 2 wrong link & wrong model names in the docstrings#40565Rocketknight1 merged 5 commits intohuggingface:mainfrom
Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: metaclip_2 |
|
Hi @NielsRogge ! I am the first author of MetaCLIP 2, and I just wanted to fix some errors on the model names in the documentation of MetaCLIP 2. Can you help me on reviewing this PR? Thanks so much! |
|
run-slow: metaclip_2 |
|
This comment contains run-slow, running the specified jobs: models: ['models/metaclip_2'] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Rocketknight1
left a comment
There was a problem hiding this comment.
Hi @voidism, sorry for the delay! I'm happy to approve this one quickly - the links are clearly broken in the existing code. If the relevant maintainers have any issues, they can ping me here when they get back and I can open a follow-up PR to fix it.
|
Hi @Rocketknight1 –it looks great to me! Thanks a lot for your help! |
|
Thanks @voidism for taking this up! |
|
@NielsRogge Thank you for integrating MetaCLIP 2 into HF! |
What does this PR do?
The new model support for MetaCLIP 2 is done, but the documentation is with the wrong links and wrong model names.
The issue is already mentioned by @howardhsu in #39826 (comment)_
@NielsRogge tried to fix it in #39826 (comment)_ but it seems not trivial to fix because the modular model converter caused it.
Also, as mentioned by @ArthurZucker in #39826 (comment)_
I just finished exactly what @ArthurZucker suggested to overwrite the full docstring! 🤗
I didn't modify any functionality other than the docstrings.
Fixes #39826
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @howardhsu @NielsRogge
Documentation: @stevhliu