Skip to content

fix: gas for gemma fixed#40591

Merged
SunMarc merged 5 commits intohuggingface:mainfrom
yevvonlim:fix/gemm3-ga
Sep 3, 2025
Merged

fix: gas for gemma fixed#40591
SunMarc merged 5 commits intohuggingface:mainfrom
yevvonlim:fix/gemm3-ga

Conversation

@yevvonlim
Copy link
Copy Markdown
Contributor

@yevvonlim yevvonlim commented Sep 1, 2025

What does this PR do?

Fixes #40564

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@zach-huggingface, @SunMarc and @qgallouedec

Copy link
Copy Markdown
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! You need to propagate the fix with make fix-copies

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 3, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma3

@yevvonlim
Copy link
Copy Markdown
Contributor Author

done!

@SunMarc SunMarc enabled auto-merge (squash) September 3, 2025 08:37
Copy link
Copy Markdown
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc merged commit 0f5e45a into huggingface:main Sep 3, 2025
18 checks passed
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loss Scales Incorrectly with Gradient Accumulation Steps in Trainer (Gemma3 and other models)

3 participants