Merged
Conversation
vasqu
commented
Sep 1, 2025
| ): | ||
| mrope_section = config.rope_scaling["mrope_section"] | ||
| mutiplier = max(requested_dim // head_dim, 1) | ||
| config.rope_scaling = {"type": "default", "mrope_section": [i * mutiplier for i in mrope_section]} |
Contributor
Author
There was a problem hiding this comment.
Other logic is a few lines down
transformers/tests/test_modeling_common.py
Lines 4792 to 4798 in 8564e21
Contributor
Author
|
Seems like the failed tests are the same as in main, ie CI is currently broken |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
approved these changes
Sep 1, 2025
Member
zucchini-nlp
left a comment
There was a problem hiding this comment.
Good catch, i blindly trusted GH rebase process 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase/merge didnt remove the logic in #40490 because they were done at 2 different lines in the code
cc @zucchini-nlp