Skip to content

Add codebook_dim attribute to DacVectorQuantize for DacResidualVectorQuantize.from_latents()#40665

Merged
vasqu merged 4 commits intohuggingface:mainfrom
flavioialongo:fix-missing-dac-quantizer-parameter
Sep 4, 2025
Merged

Add codebook_dim attribute to DacVectorQuantize for DacResidualVectorQuantize.from_latents()#40665
vasqu merged 4 commits intohuggingface:mainfrom
flavioialongo:fix-missing-dac-quantizer-parameter

Conversation

@flavioialongo
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes an issue where DacResidualVectorQuantize.from_latents required an additional attribute from the DacVectorQuantize class.

  • Added the missing instance attribute in the class initialization.
  • Prevents runtime errors when calling from_latents.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Your PR will be replied to more quickly if you can figure out the right person to tag with @
@eustlb

Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a test? audio tokenizer cc @ebezzam

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 3, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: dac

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Sep 4, 2025

run-slow: dac

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

This comment contains run-slow, running the specified jobs:

models: ['models/dac']
quantizations: [] ...

Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @flavioialongo 🤗 gonna merge after docs have been built (nothing to be done on your side)

@vasqu vasqu enabled auto-merge (squash) September 4, 2025 11:23
@vasqu vasqu merged commit 91b34be into huggingface:main Sep 4, 2025
20 checks passed
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@flavioialongo flavioialongo deleted the fix-missing-dac-quantizer-parameter branch September 4, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants