Skip to content

Remove overwritten GitModelTest::test_beam_search_generate#40666

Merged
ydshieh merged 1 commit intomainfrom
bobo2
Sep 3, 2025
Merged

Remove overwritten GitModelTest::test_beam_search_generate#40666
ydshieh merged 1 commit intomainfrom
bobo2

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Sep 3, 2025

What does this PR do?

This test overwrites the one from GenerationTesterMixin

and we have it being flaky

FAILED tests/models/git/test_modeling_git.py::GitModelTest::test_beam_search_generate - AssertionError: torch.Size([26, 16]) != (26, 20)

https://app.circleci.com/pipelines/github/huggingface/transformers/144061/workflows/5cf0ad7e-25c7-4396-8e17-f58dfdf0adbf/jobs/1904264/parallel-runs/6

The GenerationTesterMixin::test_beam_search_generate has some new updates after GitModelTest::test_beam_search_generate being added.

Remove the overwritten one and the test works well: all pass in 3000 runs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 3, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: git

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Contributor

@manueldeprada manueldeprada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!! 🧹 ❤️

@ydshieh ydshieh merged commit afd1393 into main Sep 3, 2025
19 checks passed
@ydshieh ydshieh deleted the bobo2 branch September 3, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants