Fix self.dropout_p is not defined for SamAttention/Sam2Attention#40667
Merged
Cyrilvallez merged 2 commits intohuggingface:mainfrom Sep 4, 2025
Merged
Fix self.dropout_p is not defined for SamAttention/Sam2Attention#40667Cyrilvallez merged 2 commits intohuggingface:mainfrom
Cyrilvallez merged 2 commits intohuggingface:mainfrom
Conversation
yonigozlan
added
the
for patch
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: sam, sam2, sam2_video, sam_hq |
vasqu
reviewed
Sep 3, 2025
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Do the other models not have dropout anymore? See #40255 (comment) please, it was there before
Member
Author
|
It was there for VisionAttention (and still is ;) ), but not for the Attention class that is used in the mask decoder |
vasqu
approved these changes
Sep 3, 2025
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Ah, now i see it - there are two attentions my bad
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
Nit: Is there any tests for training? Might be good to add if you have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #40255 (comment)
self.dropout_pshouldn't be used for SamAttention/Sam2Attention, only for RoPE attention (memory attention) in Sam2Video