Skip to content

Avoid night torch CI not run because of irrelevant docker image failing to build #40677

Merged
ydshieh merged 1 commit intomainfrom
nightly_ci
Sep 4, 2025
Merged

Avoid night torch CI not run because of irrelevant docker image failing to build #40677
ydshieh merged 1 commit intomainfrom
nightly_ci

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Sep 4, 2025

What does this PR do?

Currently, the workflow

.github/workflows/self-nightly-caller.yml

calls

  build_nightly_torch_ci_images:
    name: Build CI Docker Images with nightly torch
    uses: ./.github/workflows/build-nightly-ci-docker-images.yml

which builds 2 docker images in 2 jobs

  latest-with-torch-nightly-docker:
  nightly-torch-deepspeed-docker:

However, after #40306,

.github/workflows/self-nightly-caller.yml

only calls model-ci and no longer call deepspeed-ci, see

https://github.com/huggingface/transformers/pull/40306/files#r2287368451

And we only need to build latest-with-torch-nightly-docker image for model-ci instead of the 2 docker image.

Before this PR, we had nightly-torch-deepspeed-docker fails to build

https://github.com/huggingface/transformers/actions/runs/17431117913

and prevent the nightly torch CI to be run, which is not good.

This PR avoids this situation by adding if conditions in the 2 jobs in build-nightly-ci-docker-images.yml

@ydshieh ydshieh changed the title Separate the doc Avoid night torch CI not run because of irrelevant docker image failing to build Sep 4, 2025
@ydshieh ydshieh merged commit ca9b36a into main Sep 4, 2025
21 of 22 checks passed
@ydshieh ydshieh deleted the nightly_ci branch September 4, 2025 07:06
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants