Final test data cache - inside CI docker images#40689
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
Author
|
cc @zucchini-nlp too |
manueldeprada
approved these changes
Sep 4, 2025
Contributor
manueldeprada
left a comment
manueldeprada
left a comment
There was a problem hiding this comment.
Oh this js a much better solution than what I proposed. Thanks a lot!!
zucchini-nlp
approved these changes
Sep 4, 2025
Comment on lines
-1212
to
+1216
| "https://www.ilankelman.org/stopsigns/australia.jpg", | ||
| "https://www.ilankelman.org/stopsigns/australia.jpg", | ||
| ], | ||
| url_to_local_path( | ||
| "https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/transformers/tasks/australia.jpg" | ||
| ) | ||
| ] | ||
| * 2, |
Member
There was a problem hiding this comment.
cool, can you approve #40684 (comment) pls and we'll be done with processor tests 🤞🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cache the test data during the CI docker image build time.
Hope you would be happy with this :-) @manueldeprada
I tried with the dev images which works. I will push the real images then merge if you are happy.