Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
Could you run a few integration tests to make sure 🙏 Thank you. |
MekkCyber
approved these changes
Oct 2, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Finallyyyy 🔥 ! Great clean up
Open
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: aya_vision, chameleon, colqwen2, diffllama, emu3, ernie4_5_moe, esm, falcon, gemma |
Member
Author
|
run-slow: bnb |
Member
Author
|
run-slow: gemma |
Contributor
|
This comment contains run-slow, running the specified jobs: models: ['models/gemma'] |
Collaborator
|
hahha have it in #41445 as well for from_pretrained |
AhnJoonSung
pushed a commit
to AhnJoonSung/transformers
that referenced
this pull request
Oct 12, 2025
* [v5] remove load_in_4bit and load_in_8bit * fix * reveert * fix --------- Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
load_in_4bitandload_in_8bitdeprecated arguments for v5. This is something that I didn't want to do in a minor release as this might be breaking for a lot of users.