Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
What issues are in hf parser? |
It has trouble dealing with union of different types and there were some strange cases involving optional. As you can see in this pr, --fsdp arg was incorrectly parsed. We need to fix the parser at some point ;) |
|
@SunMarc The current behaviour was made by me. Now if not specified |
|
If you are interested in fixing the parser, you can use play with the following script and use for example from transformers import TrainingArguments, HfArgumentParser
parser = HfArgumentParser((TrainingArguments,))
training_args, = parser.parse_args_into_dataclasses()The tests should be fixed by this PR but this is not a proper fix tbh |
|
@SunMarc Yes, give me time to reproduce and fix. |
Cyrilvallez
left a comment
There was a problem hiding this comment.
Thanks! Trusting you here for fsdp!
* Fix tests * fix ! * fix
* Fix tests * fix ! * fix
What does this PR do?
This PR fixes all fsdp tests as there were some regressions:
fused_adamw_torch(new default for users with torch >=2.8) + fp16 + FSDP don't work cc @winglian @qgallouedec did you face this issue ?fsdp_config, this was broken for way too longRun tests with 2 gpus
RUN_SLOW=True pytest tests/fsdp/test_fsdp.py