[Fix] dots1 expert bias routing#41663
Merged
vasqu merged 2 commits intohuggingface:mainfrom Dec 2, 2025
Merged
Conversation
Contributor
Author
|
Reminder: I think the dots1 model is still broken on main @ArthurZucker, not sure if this PR is the best way to address this, though. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: dots1 |
4 tasks
vasqu
approved these changes
Dec 2, 2025
Contributor
vasqu
left a comment
There was a problem hiding this comment.
LGTM, I double checked and this looks correct to me. The selection is affected by the e_score_bias but not the final logits that are then selected.
Imo, we could refactor this later on to be within the router instead! (including deepseek). cc @3outeille since you worked a lot on MoEs recently it might be interesting
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sarathc-cerebras
pushed a commit
to sarathc-cerebras/transformers
that referenced
this pull request
Dec 7, 2025
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow up to #41647. I went over the model code again and noticed that the dots1 routing apparently also broke in #40132. dots1 seems to be very close in architecture to Deepseek V3 but not explcitly dependent. Not sure if there is a more elegant way to fix this?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker