Add LightGlue fast image processor#41670
Merged
yonigozlan merged 4 commits intohuggingface:mainfrom Oct 21, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
reviewed
Oct 17, 2025
Contributor
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
cool! left minor comments
| Whether to convert the image to grayscale. Can be overridden by `do_grayscale` in the `preprocess` method. | ||
| """ | ||
|
|
||
| do_grayscale: bool |
Contributor
There was a problem hiding this comment.
convert_to_grayscale maybe?
Member
Author
There was a problem hiding this comment.
Agreed it's better but it would be breaking BC :(
Comment on lines
+98
to
+100
| This function is supposed to return a 1-channel image, but it returns a 3-channel image with the same value in each | ||
| channel, because of an issue that is discussed in : | ||
| https://github.com/huggingface/transformers/pull/25786#issuecomment-1730176446 |
Member
Author
There was a problem hiding this comment.
Not sure if this is still a problem, but better to keep it just in case
Contributor
There was a problem hiding this comment.
yeah not a big issue, it's just funny to see
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, lightglue |
Member
Author
|
Thanks for the review @molbap ! It should be good now :) |
molbap
approved these changes
Oct 20, 2025
Contributor
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
Alright, looks good to me! Nice work!
| Whether to convert the image to grayscale. Can be overridden by `do_grayscale` in the `preprocess` method. | ||
| """ | ||
|
|
||
| do_grayscale: bool |
Comment on lines
+98
to
+100
| This function is supposed to return a 1-channel image, but it returns a 3-channel image with the same value in each | ||
| channel, because of an issue that is discussed in : | ||
| https://github.com/huggingface/transformers/pull/25786#issuecomment-1730176446 |
Contributor
There was a problem hiding this comment.
yeah not a big issue, it's just funny to see
Comment on lines
+232
to
+239
| class LightGlueImageProcessorFast(SuperGlueImageProcessorFast): | ||
| def post_process_keypoint_matching( | ||
| self, | ||
| outputs: LightGlueKeypointMatchingOutput, | ||
| target_sizes: Union[TensorType, list[tuple]], | ||
| threshold: float = 0.0, | ||
| ) -> list[dict[str, torch.Tensor]]: | ||
| return super().post_process_keypoint_matching(outputs, target_sizes, threshold) |
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
* add fast image processor skel * add working lightglue fast image processor + tests * remove plot_keypoint_matching
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
* add fast image processor skel * add working lightglue fast image processor + tests * remove plot_keypoint_matching
81 tasks
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* add fast image processor skel * add working lightglue fast image processor + tests * remove plot_keypoint_matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the title says